Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMLIV/DRIV #460

Merged
merged 22 commits into from
Aug 12, 2021
Merged

DMLIV/DRIV #460

merged 22 commits into from
Aug 12, 2021

Conversation

heimengqi
Copy link
Contributor

No description provided.

@heimengqi heimengqi marked this pull request as ready for review June 21, 2021 20:02
@heimengqi heimengqi requested review from vsyrgkanis, kbattocchi and moprescu and removed request for vsyrgkanis and kbattocchi June 21, 2021 20:03
kbattocchi
kbattocchi requested changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good; added a few suggestions and I'm still going through the DRIV changes and will add a second review once I'm done with that.

econml/dr/_drlearner.py Outdated Show resolved Hide resolved
econml/dr/_drlearner.py Outdated Show resolved Hide resolved
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
econml/iv/dml/_dml.py Show resolved Hide resolved
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
econml/sklearn_extensions/linear_model.py Outdated Show resolved Hide resolved
econml/sklearn_extensions/linear_model.py Show resolved Hide resolved
econml/tests/test_dowhy.py Show resolved Hide resolved
vsyrgkanis
vsyrgkanis reviewed Jul 23, 2021
View reviewed changes
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
vsyrgkanis
vsyrgkanis reviewed Jul 23, 2021
View reviewed changes
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
econml/sklearn_extensions/linear_model.py Outdated Show resolved Hide resolved
econml/sklearn_extensions/linear_model.py Outdated Show resolved Hide resolved
econml/iv/dml/_dml.py Show resolved Hide resolved
econml/iv/dml/_dml.py Outdated Show resolved Hide resolved
vsyrgkanis
vsyrgkanis reviewed Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@vsyrgkanis vsyrgkanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMLIV Looks good except for the comments I already raised.

vsyrgkanis
vsyrgkanis reviewed Jul 24, 2021
View reviewed changes
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
@vsyrgkanis
Copy link
Collaborator

I reviewed code up and before the IntentToTreat!
Looks great. Only one potential major change is requested. Have not run quick sanity checks also. Will do once I finish the IntentToTreat code pass.

vsyrgkanis
vsyrgkanis reviewed Jul 25, 2021
View reviewed changes
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
@vsyrgkanis
Copy link
Collaborator

I finished going over the whole driv code. So all code seems good, except for comments raised!

vsyrgkanis
vsyrgkanis reviewed Jul 25, 2021
View reviewed changes
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
vsyrgkanis
vsyrgkanis reviewed Jul 25, 2021
View reviewed changes
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
econml/iv/dr/_dr.py Show resolved Hide resolved
vsyrgkanis
vsyrgkanis reviewed Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@vsyrgkanis vsyrgkanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

econml/iv/dr/_dr.py Outdated Show resolved Hide resolved
kbattocchi
kbattocchi approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@heimengqi heimengqi enabled auto-merge (squash) August 11, 2021 17:33
@heimengqi heimengqi merged commit 063784e into master Aug 12, 2021
@heimengqi heimengqi deleted the mehei/driv branch August 12, 2021 21:40
This was referenced Mar 28, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsyrgkanis vsyrgkanis vsyrgkanis left review comments

@kbattocchi kbattocchi kbattocchi approved these changes

@moprescu moprescu Awaiting requested review from moprescu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heimengqi @vsyrgkanis @kbattocchi