Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Adjust deprecation messages #919

Merged
merged 4 commits into from
May 29, 2022
Merged

Conversation

MartinThoma
Copy link
Member

We are trying to break as few running systems as possible. For this
reason we keep the adapter methods / classes in PyPDF2 until 3.0.0.

This commit is done to not confuse people. It will not be backported
to the 1.x branch though.

MartinThoma and others added 3 commits May 28, 2022 11:36
We are trying to break as few running systems as possible. For this
reason we keep the adapter methods / classes in PyPDF2 until 3.0.0.

This commit is done to not confuse people. It will not be backported
to the 1.x branch though.
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #919 (f8e5d1a) into main (07bb859) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files          16       16           
  Lines        4327     4327           
  Branches      812      812           
=======================================
  Hits         3367     3367           
  Misses        788      788           
  Partials      172      172           
Impacted Files Coverage Δ
PyPDF2/_page.py 79.37% <ø> (ø)
PyPDF2/_reader.py 77.01% <ø> (ø)
PyPDF2/_writer.py 78.90% <ø> (ø)
PyPDF2/generic.py 77.77% <ø> (ø)
PyPDF2/xmp.py 52.06% <ø> (ø)
PyPDF2/__init__.py 100.00% <100.00%> (ø)
PyPDF2/_utils.py 89.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07bb859...f8e5d1a. Read the comment docs.

@MartinThoma MartinThoma merged commit 7647ab5 into main May 29, 2022
@MartinThoma MartinThoma deleted the adjust-deprecation-message branch May 29, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants