TST: Extending typing to tests; cover generic and scripts folder files

.github/workflows/github-ci.yaml

@@ -262,7 +262,7 @@ jobs:
         ruff check .
     - name: Test with mypy
       run : |
-        mypy pypdf
+        mypy pypdf tests/generic tests/scripts
     - name: Install docs requirements
       run: |
         pip install -r requirements/docs.txt

pypdf/generic/_image_xobject.py

@@ -181,7 +181,7 @@ def _handle_flate(
     size: tuple[int, int],
     data: bytes,
     mode: mode_str_type,
-    color_space: str,
+    color_space: ArrayObject,
     colors: int,
     obj_as_text: str,
 ) -> tuple[Image.Image, str, str, bool]:

pyproject.toml

@@ -248,4 +248,4 @@ disallow_incomplete_defs = true
 warn_redundant_casts = true
 warn_unused_ignores = true
 warn_unused_configs = true
-exclude = ['venv', '.venv', 'tests', 'make_release.py']
+exclude = ['venv', '.venv', 'make_release.py']

tests/generic/test_base.py

@@ -22,7 +22,7 @@ def test_text_string_object__looks_like_bom(source: bytes, expected: str) -> Non
 
 
 @pytest.mark.enable_socket
-def test_text_string_object__wrongly_detected_bom():
+def test_text_string_object__wrongly_detected_bom() -> None:
     url = "https://github.com/user-attachments/files/24401507/minimal.pdf"
     name = "issue3587.pdf"
     reader = PdfReader(BytesIO(get_data_from_url(url, name=name)))

tests/generic/test_data_structures.py

@@ -25,10 +25,10 @@
 try:
     import resource
 except ImportError:
-    resource = None
+    resource = None  # type: ignore[assignment]
 
 
-def test_dictionary_object__get_next_object_position():
+def test_dictionary_object__get_next_object_position() -> None:
     reader = PdfReader(RESOURCE_ROOT / "crazyones.pdf")
 
     # reader.xref = {0: {7: 15, 9: 10245, 12: 939, 14: 2999, 16: 4982, 18: 9949, 22: 11160}}
@@ -49,12 +49,14 @@ def test_dictionary_object__get_next_object_position():
     ) == 15
 
 
-def test_tree_object__cyclic_reference(caplog):
+def test_tree_object__cyclic_reference(caplog: pytest.LogCaptureFixture) -> None:
     writer = PdfWriter()
     child1 = writer._add_object(DictionaryObject())
     child2 = writer._add_object(DictionaryObject({NameObject("/Next"): child1}))
     child3 = writer._add_object(DictionaryObject({NameObject("/Next"): child2}))
-    child1.get_object()[NameObject("/Next")] = child3
+    obj = child1.get_object()
+    if isinstance(obj, dict):
+        obj[NameObject("/Next")] = child3
     tree = TreeObject()
     tree[NameObject("/First")] = child2
     tree[NameObject("/Last")] = writer._add_object(DictionaryObject())
@@ -64,7 +66,7 @@ def test_tree_object__cyclic_reference(caplog):
 
 
 @pytest.mark.enable_socket
-def test_array_object__clone_same_object_multiple_times(caplog):
+def test_array_object__clone_same_object_multiple_times(caplog: pytest.LogCaptureFixture) -> None:
     url = "https://github.com/user-attachments/files/25412858/Draft_OSMF_financial_statement_2013.pdf"
     name = "issue2991.pdf"
     reader = PdfReader(BytesIO(get_data_from_url(url=url, name=name)))
@@ -76,7 +78,7 @@ def test_array_object__clone_same_object_multiple_times(caplog):
     assert caplog.messages == []
 
 
-def test_array_object__clone_same_stream_multiple_times():
+def test_array_object__clone_same_stream_multiple_times() -> None:
     writer = PdfWriter()
 
     # Unique streams.
@@ -87,7 +89,8 @@ def test_array_object__clone_same_stream_multiple_times():
 
     # Shared streams.
     shared_streams = [StreamObject() for _ in range(3)]
-    [shared_stream.set_data(f"Shared stream {index}".encode()) for index, shared_stream in enumerate(shared_streams)]
+    for index, shared_stream in enumerate(shared_streams):
+        shared_stream.set_data(f"Shared stream {index}".encode())
 
     # Add to writer.
     writer._add_object(stream1)
@@ -121,7 +124,7 @@ def test_array_object__clone_same_stream_multiple_times():
 
 
 @pytest.mark.enable_socket
-def test_dictionary_object__read_from_stream__limit():
+def test_dictionary_object__read_from_stream__limit() -> None:
     name = "read_from_stream__length_2gb.pdf"
     url = "https://github.com/user-attachments/files/25842437/read_from_stream__length_2gb.pdf"
 
@@ -164,7 +167,7 @@ def limit_virtual_memory() -> None:
 @pytest.mark.enable_socket
 @pytest.mark.skipif(condition=resource is None, reason="Does not have 'resource' module.")
 @pytest.mark.skipif(sys.platform == "darwin", reason="RLIMIT_AS is unreliable.")
-def test_dictionary_object__read_from_stream__no_limit(tmp_path):
+def test_dictionary_object__read_from_stream__no_limit(tmp_path: Path) -> None:
     pdf_path_str, env, limit_virtual_memory = _prepare_test_dictionary_object__read_from_stream__no_limit(tmp_path)
 
     source_file = tmp_path / "script.py"
@@ -196,7 +199,7 @@ def test_dictionary_object__read_from_stream__no_limit(tmp_path):
 @pytest.mark.enable_socket
 @pytest.mark.skipif(condition=resource is None, reason="Does not have 'resource' module.")
 @pytest.mark.skipif(sys.platform == "darwin", reason="RLIMIT_AS is unreliable.")
-def test_dictionary_object__read_from_stream__no_limit__path(tmp_path):
+def test_dictionary_object__read_from_stream__no_limit__path(tmp_path: Path) -> None:
     pdf_path_str, env, limit_virtual_memory = _prepare_test_dictionary_object__read_from_stream__no_limit(tmp_path)
 
     source_file = tmp_path / "script.py"