Skip to content

MAINT: Tweak class PageObject #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

MAINT: Tweak class PageObject #3266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ece2ae
MAINT: Tweak class PageObject
j-t-1 Apr 24, 2025
91a0dd8
Update pypdf/_page.py
stefan6419846 Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions pypdf/_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,6 @@ def __init__(
DictionaryObject.__init__(self)
self.pdf = pdf
self.inline_images: Optional[Dict[str, ImageFile]] = None
# below Union for mypy but actually Optional[List[str]]
self.indirect_reference = indirect_reference
if not is_null_or_none(indirect_reference):
assert indirect_reference is not None, "mypy"
Expand Down Expand Up @@ -1116,11 +1115,11 @@ def merge_page(
"""
Merge the content streams of two pages into one.

Resource references
(i.e. fonts) are maintained from both pages. The mediabox/cropbox/etc
of this page are not altered. The parameter page's content stream will
be added to the end of this page's content stream, meaning that it will
be drawn after, or "on top" of this page.
Resource references (e.g. fonts) are maintained from both pages.
The mediabox, cropbox, etc of this page are not altered.
The parameter page's content stream will
be added to the end of this page's content stream,
meaning that it will be drawn after, or "on top" of this page.

Args:
page2: The page to be merged into this one. Should be
Expand Down Expand Up @@ -1569,31 +1568,28 @@ def add_transformation(
for i in range(0, 8, 2)
]

lowerleft = (min(new_x), min(new_y))
upperright = (max(new_x), max(new_y))

self.mediabox.lower_left = lowerleft
self.mediabox.upper_right = upperright
self.mediabox.lower_left = (min(new_x), min(new_y))
self.mediabox.upper_right = (max(new_x), max(new_y))

def scale(self, sx: float, sy: float) -> None:
"""
Scale a page by the given factors by applying a transformation matrix
to its content and updating the page size.

This updates the mediabox, the cropbox, and the contents
of the page.
This updates the various page boundaries (mediabox, cropbox, etc.)
and the contents of the page.

Args:
sx: The scaling factor on horizontal axis.
sy: The scaling factor on vertical axis.

"""
self.add_transformation((sx, 0, 0, sy, 0, 0))
self.mediabox = self.mediabox.scale(sx, sy)
self.cropbox = self.cropbox.scale(sx, sy)
self.artbox = self.artbox.scale(sx, sy)
self.bleedbox = self.bleedbox.scale(sx, sy)
self.trimbox = self.trimbox.scale(sx, sy)
self.mediabox = self.mediabox.scale(sx, sy)
self.artbox = self.artbox.scale(sx, sy)

if PG.ANNOTS in self:
annotations = self[PG.ANNOTS]
Expand Down
Loading