Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Ressources → Resources (and internal name childs) #2550

Merged
merged 5 commits into from
Mar 29, 2024
Merged

MAINT: Ressources → Resources (and internal name childs) #2550

merged 5 commits into from
Mar 29, 2024

Conversation

pubpub-zz
Copy link
Collaborator

closes #2548

@pubpub-zz
Copy link
Collaborator Author

I've not been able to change childs into children : the Destination(Object) derivates from TreeObjects which has children member. any ideas

@pubpub-zz pubpub-zz changed the title MNT: depreciate Resources and childs MAINT: depreciate Resources and childs Mar 27, 2024
@pubpub-zz pubpub-zz changed the title MAINT: depreciate Resources and childs MAINT: depreciate Ressources and childs Mar 27, 2024
@MartinThoma MartinThoma changed the title MAINT: depreciate Ressources and childs MAINT: deprecate Ressources and childs Mar 27, 2024
@MartinThoma MartinThoma changed the title MAINT: deprecate Ressources and childs MAINT: Ressources → Resources Mar 27, 2024
@stefan6419846
Copy link
Collaborator

the Destination(Object) derivates from TreeObjects which has children member. any ideas

Does the Destination need both attributes or do we only need one - id est, what is the difference between children and childs at the moment?

@pubpub-zz
Copy link
Collaborator Author

actually the field is for pypdf internal use only. I've fixed the name

@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (12c3784) to head (a2bb48c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2550   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files          50       50           
  Lines        8230     8231    +1     
  Branches     1646     1646           
=======================================
+ Hits         7792     7793    +1     
  Misses        268      268           
  Partials      170      170

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefan6419846 stefan6419846 changed the title MAINT: Ressources → Resources MAINT: Ressources → Resources (and internal name childs) Mar 29, 2024
@stefan6419846 stefan6419846 merged commit 719ff25 into py-pdf:main Mar 29, 2024
16 checks passed
stefan6419846 added a commit that referenced this pull request Apr 7, 2024
@stefan6419846
REL: 4.2.0
2ac88e6 
REL: 4.2.0

## What's new

### New Features (ENH)
- Allow multiple charsets for NameObject.read_from_stream (#2585) by @pubpub-zz
- Add support for /Kids in page labels (#2562) by @stefan6419846
- Allow to update fields on many pages (#2571) by @pubpub-zz
- Tolerate PDF with invalid xref pointed objects (#2335) by @pubpub-zz
- Add Enforce from PDF2.0 in viewer_preferences (#2511) by @pubpub-zz
- Add += and -= operators to ArrayObject (#2510) by @pubpub-zz

### Bug Fixes (BUG)
- Fix merge_page sometimes generating unknown operator 'QQ' (#2588) by @rfotino
- Fix fields update where annotations are kids of field (#2570) by @pubpub-zz
- Process CMYK images without a filter correctly (#2557) by @pubpub-zz
- Extract text in layout mode without finding resources (#2555) by @pubpub-zz
- Prevent recursive loop in some PDF files (#2505) by @pubpub-zz

### Robustness (ROB)
- Tolerate "truncated" xref (#2580) by @pubpub-zz
- Replace error by warning for EOD in RunLengthDecode/ASCIIHexDecode (#2334) by @pubpub-zz
- Rebuild xref table if one entry is invalid (#2528) by @pubpub-zz
- Robustify stream extraction (#2526) by @pubpub-zz

### Documentation (DOC)
- Update release process for latest changes (#2564) by @stefan6419846
- Encryption/decryption: Clone document instead of copying all pages (#2546) by @redfast00
- Minor improvements (#2542) by @j-t-1
- Update annotation list (#2534) by @j-t-1
- Update references and formatting (#2529) by @j-t-1
- Correct threads reference, plus minor changes (#2521) by @j-t-1
- Minor readability increases (#2515) by @j-t-1
- Simplify PaperSize examples (#2504) by @j-t-1
- Minor improvements (#2501) by @j-t-1

### Developer Experience (DEV)
- Remove unused dependencies (#2572) by @stefan6419846
- Remove page labels PR link from message (#2561) by @stefan6419846
- Fix changelog generator regarding whitespace and handling of "Other" group (#2492) by @stefan6419846
- Add REL to known PR prefixes (#2554) by @stefan6419846
- Release using the REL commit instead of git tag (#2500) by @MartinThoma
- Unify code between PdfReader and PdfWriter (#2497) by @pubpub-zz
- Bump softprops/action-gh-release from 1 to 2 (#2514) by @dependabot[bot]

### Maintenance (MAINT)
- Ressources → Resources (and internal name childs) (#2550) by @pubpub-zz
- Fix typos found by codespell (#2549) by @stefan6419846
- Update Read the Docs configuration (#2538) by @j-t-1
- Add root_object, _info and _ID to PdfReader (#2495) by @pubpub-zz

### Testing (TST)
- Allow loading truncated images if required (#2586) by @stefan6419846
- Fix download issues from #2562 (#2578) by @pubpub-zz
- Improve test_get_contents_from_nullobject to show real use-case (#2524) by @stefan6419846
- Add missing test annotations (#2507) by @stefan6419846

[Full Changelog](4.1.0...4.2.0)
ztravis
ztravis reviewed May 31, 2024
View reviewed changes
pypdf/constants.py
"""

@classmethod # type: ignore
@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works for python 3.9 and 3.10...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztravis ztravis ztravis left review comments

@stefan6419846 stefan6419846 stefan6419846 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate public APIs containing typos
3 participants
@pubpub-zz @stefan6419846 @ztravis