ENH: Extend PdfWriter.append() to PageObjects #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1704 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 33 33
Lines 6480 6482 +2
Branches 1281 1282 +1
=======================================
+ Hits 5986 5988 +2
Misses 320 320
Partials 174 174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MartinThoma
changed the title
MartinThoma
changed the title
|
I don't know if you are waiting for this... but it's all yours 😉 |
|
Hahaha, I don't remember if it was this PR, but I was actually missing that comment for one PR yesterday 😄 👍 |
MartinThoma
changed the title
|
It's merged - thank you :-) |
MartinThoma
added a commit
that referenced
this pull request
Mar 18, 2023
New Features (ENH) - Extend PdfWriter.append() to PageObjects (#1704) - Support qualified names in update_page_form_field_values (#1695) Robustness (ROB) - Tolerate streams without length field (#1717) - Accept DictionaryObject in /D of NamedDestination (#1720) - Widths def in cmap calls IndirectObject (#1719)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend append/Merge to pass PageObject list to ease some processing