DEV: Use ruff in CI (#1609)

.github/workflows/github-ci.yaml

@@ -111,9 +111,9 @@ jobs:
     - name: Install pypdf
       run: |
         pip install .
-    - name: Test with flake8
+    - name: Test with ruff
       run: |
-        flake8 .
+        ruff .
 
   package:
     name: Build & verify package

.pre-commit-config.yaml

@@ -39,7 +39,6 @@ repos:
         additional_dependencies: [black==22.1.0]
         exclude: "docs/user/robustness.md"
 -   repo: https://github.com/charliermarsh/ruff-pre-commit
-    # Ruff version.
     rev: 'v0.0.237'
     hooks:
     -   id: ruff

pypdf/_page.py

@@ -498,9 +498,7 @@ def rotation(self) -> int:
         valid values. This property does not affect ``/Contents``.
         """
         rotate_obj = self.get(PG.ROTATE, 0)
-        return (
-            rotate_obj if isinstance(rotate_obj, int) else rotate_obj.get_object()
-        )
+        return rotate_obj if isinstance(rotate_obj, int) else rotate_obj.get_object()
 
     @rotation.setter
     def rotation(self, r: Union[int, float]) -> None:
@@ -651,8 +649,8 @@ def compute_unique_key(base_key: str) -> Tuple[str, bool]:
                     new_res[newname] = page2res.raw_get(key)
             lst = sorted(new_res.items())
             new_res.clear()
-            for l in lst:
-                new_res[l[0]] = l[1]
+            for el in lst:
+                new_res[el[0]] = el[1]
         return new_res, rename_res
 
     @staticmethod
@@ -1263,7 +1261,8 @@ def mergeRotatedScaledPage(
         """
         deprecation_with_replacement(
             "page.mergeRotatedScaledPage(page2, rotation, scale, expand)",
-            "page.merge_transformed_page(page2, Transformation().rotate(rotation).scale(scale)); page.merge_page(page2, expand)",
+            "page.merge_transformed_page(page2, Transformation()"
+            ".rotate(rotation).scale(scale)); page.merge_page(page2, expand)",
             "3.0.0",
         )
         op = Transformation().rotate(rotation).scale(scale, scale)

requirements/ci-3.11.txt

@@ -56,6 +56,8 @@ pytest==7.2.0
     #   pytest-benchmark
 pytest-benchmark==4.0.0
     # via -r requirements/ci.in
+ruff==0.0.241
+    # via -r requirements/ci.in
 typeguard==2.13.3
     # via -r requirements/ci.in
 types-dataclasses==0.6.6

requirements/ci.in

@@ -5,9 +5,9 @@ flake8-bugbear
 flake8-print
 mypy
 pillow
+pycryptodome
 pytest
 pytest-benchmark
-pycryptodome
 typeguard
-types-Pillow
 types-dataclasses
+types-Pillow