Skip to content

Conversation

s3alfisc
Copy link
Member

@s3alfisc s3alfisc commented Mar 24, 2025

  • Implements options fixef_k = "nested" and fixef_k = "full"
  • Makes fixef_k = "nested" the default to match fixest out of the box
  • some cleanups of the FixestMulti class

Closes #501
Closes #260.

s3alfisc added 30 commits March 8, 2025 17:40
Copy link

codecov bot commented Mar 30, 2025

Codecov Report

Attention: Patch coverage is 69.64286% with 34 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pyfixest/utils/utils.py 38.88% 33 Missing ⚠️
pyfixest/report/summarize.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
core-tests 79.84% <66.96%> (-0.57%) ⬇️
tests-extended ?
tests-vs-r 47.83% <69.64%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pyfixest/estimation/FixestMulti_.py 81.38% <100.00%> (-2.57%) ⬇️
pyfixest/estimation/feols_.py 83.52% <100.00%> (-6.80%) ⬇️
pyfixest/estimation/fepois_.py 90.04% <100.00%> (+0.13%) ⬆️
pyfixest/estimation/vcov_utils.py 57.89% <100.00%> (+4.95%) ⬆️
pyfixest/report/summarize.py 87.73% <0.00%> (ø)
pyfixest/utils/utils.py 73.85% <38.88%> (-18.46%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@s3alfisc s3alfisc merged commit 69acf9d into master Mar 31, 2025
8 of 10 checks passed
@s3alfisc s3alfisc deleted the ssc branch March 31, 2025 19:53
damandhaliwal pushed a commit to damandhaliwal/pyfixest that referenced this pull request Jun 17, 2025
…ics#850)

* run extended tests on merge to master

* add function to compute non-nested fixed effects

* some progress

* confint does not match any more

* better tests, only confint fails

* clarify

* small tweak

* fix problem with confint and nested/full fixef_K

* feols tests pass

* code simplifications in FixestMulti

* cleanups

* fix test bug

* lint

* fixed effects **fully** nested

* tighten IWLS tolerance

* update readme

* tighter tolerance for fepois

* add vignette on ssc details

* update test_ssc and delete vcov tests, as they do the same thing

* update test_ssc and delete vcov tests, as they do the same thing

* update nested logic, move to numba

* fix mypy

* delete test_ssc, part of test_vs_fixest now

* tweak

* delete coverage

* ignore linter

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant