Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user creation and login #153

Merged
merged 21 commits into from
Sep 24, 2024
Merged

Implement user creation and login #153

merged 21 commits into from
Sep 24, 2024

Conversation

pwbriggs
Copy link
Owner

@pwbriggs pwbriggs commented Jul 14, 2024 •
edited
Loading

User creation, login, sessions, and authorization. We should probably also do a lot of audit logging here.

Some todo items:

  • Implement a way to bootstrap creation of first account. Discussion of methods at Add auth #70
  • Users can only be created by librarians
  • Clean up
    • Fix imports from ./ to ~/ for consistency
    • Fix Biome errors

Fixes #70

@pwbriggs pwbriggs linked an issue Jul 14, 2024 that may be closed by this pull request
Add auth #70
Closed
@pwbriggs
Copy link
Owner Author

Clarification: admins are also librarians. They just have additional permissions. When isAdmin is set on a user, isLibrarian must also.

@pwbriggs pwbriggs mentioned this pull request Jul 14, 2024
Closed
pwbriggs
pwbriggs commented Jul 14, 2024
View reviewed changes
Copy link
Owner Author

@pwbriggs pwbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soo, um, should I really be storing these credentials in the database? Maybe I could use like a secret in an env variable to encrypt the cred json?

@vercel Vercel
Copy link

vercel bot commented Sep 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
library ✅ Ready (Inspect) Visit Preview Sep 24, 2024 1:49am

@pwbriggs pwbriggs marked this pull request as ready for review September 23, 2024 04:51
@pwbriggs
Copy link
Owner Author

review phase!

@pwbriggs pwbriggs removed a link to an issue Sep 23, 2024
Add auth #70
Closed
@pwbriggs
feat: tons of work on auth & credentials
571d693 
Some incomplete but major work on implementing user creation, login, sessions, and authorization.
@pwbriggs
restructure and minor updates to createuser
1a8e542
@pwbriggs
fix styling of createuser
d30e22d
@pwbriggs
use partial type binding for readability
c14665f
@pwbriggs
finish mostly complete and workable authentication (some todos remain)
f0c3e18
@pwbriggs
add redirection to login page
778b831
@pwbriggs
require authentication & authorization to create users
70392cf
@pwbriggs
make it more obvious when creating a staff account
fe91faa
@pwbriggs
nitpicks
9536db5
@pwbriggs
redirect away from all staff routes if not authorized
40bd1cf
@pwbriggs
try using prisma url for vercel
ce6ef06
@pwbriggs
don't await bootstrapAccount()
ab32463
@pwbriggs
try removing the directUrl from Prisma
f3a5cc5
@pwbriggs
test hypothesis: neutralizing bootstrapAccount() will help with datab…
c678793 
…ase connection issues on Vercel serverless.
@pwbriggs
restructure setup flow
57ae922
@pwbriggs
remove old imports
10ce933
@pwbriggs
Remove misleading create account button
c15546e
@pwbriggs
change imports from ./ to ~/ for consistency
4c75743
@pwbriggs
change database env variable name in ci too
30729c5
@pwbriggs
fix biome errors
359154f
@pwbriggs pwbriggs enabled auto-merge (squash) September 24, 2024 01:49
@pwbriggs pwbriggs merged commit bf096e5 into main Sep 24, 2024
4 checks passed
@pwbriggs pwbriggs deleted the auth branch September 24, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auth
1 participant
@pwbriggs