Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement user creation and login #153

Draft
wants to merge 3 commits into
base: beta
Choose a base branch
from
Draft

Implement user creation and login #153

wants to merge 3 commits into from

Conversation

pwbriggs
Copy link
Owner

@pwbriggs pwbriggs commented Jul 14, 2024 •
edited
Loading

User creation, login, sessions, and authorization. We should probably also do a lot of audit logging here.

Some todo items:

  • Implement tokens and Add auth #70 (comment)
  • Users can only be created by librarians
  • Write tests
  • Clean up
    • Move credential scripts into their own directory
    • Linter... sigh
    • Fix imports from ./ to ~/ for consistency

@pwbriggs
feat: tons of work on auth & credentials
7c65f6c 
Some incomplete but major work on implementing user creation, login, sessions, and authorization.
@pwbriggs pwbriggs linked an issue Jul 14, 2024 that may be closed by this pull request
Add auth #70
Open
@pwbriggs
Copy link
Owner Author

Clarification: admins are also librarians. They just have additional permissions. When isAdmin is set on a user, isLibrarian must also.

@pwbriggs pwbriggs mentioned this pull request Jul 14, 2024
Open
pwbriggs
pwbriggs commented Jul 14, 2024
View reviewed changes
Copy link
Owner Author

@pwbriggs pwbriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soo, um, should I really be storing these credentials in the database? Maybe I could use like a secret in an env variable to encrypt the cred json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add auth
1 participant
@pwbriggs