Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Source map #378

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Source map #378

merged 2 commits into from
Aug 5, 2020

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Aug 5, 2020

Fixes #293

PR Type

Bugfix

Describe the current behavior?

A sourcemap is output, but 404's because we don't package the sourcemap for prod. This removes the sourcemap in general which we don't actually use.

Describe the new behavior?

No longer output source maps

PR Checklist

  • [ x] Test: run npm run test and ensure that all tests pass
  • [x ] Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • [ x] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@ghost
Copy link

ghost commented Aug 5, 2020

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned davrous Aug 5, 2020
Copy link
Contributor

@lee-leonardo lee-leonardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+:tiger:

@lee-leonardo lee-leonardo merged commit 1559a02 into master Aug 5, 2020
@JudahGabriel JudahGabriel deleted the sourceMap branch August 5, 2020 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error 404 pwa-install.js.map
4 participants