Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

More Bugs #119

Merged
merged 4 commits into from
Jan 7, 2020
Merged

More Bugs #119

merged 4 commits into from
Jan 7, 2020

Conversation

hipstersmoothie
Copy link
Contributor

PR Type

Bugfix

Describe the current behavior?

Found a few bugs (some that I caused). Can break up PR if need

  • Fix clicking overlay to close modal (👋)
  • The "tiny" actions footer was causing a little bit of extra scoll on some screens. switching to a smaller height does not cause this problem
  • Install button was showing on iOS always, even with usecustom. I think it was due to a paren issue. the original code was equivalent to (!this.usecustom && this.isSupportingBrowser && this.hasprompt) || this.isIOS. I think it was intended to do this though

Describe the new behavior?

Fixes the bugs

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target master branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

@ghost
Copy link

ghost commented Jan 6, 2020

Thanks for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@jgw96
Copy link
Contributor

jgw96 commented Jan 7, 2020

Hey, thanks! I had actually already fixed the background issue, but I actually like your solution better so i'm sticking with that.

@jgw96 jgw96 merged commit e7aefe8 into pwa-builder:master Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants