Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize 1.99.8.0.0 release #444

Draft
wants to merge 326 commits into
base: master
Choose a base branch
from
Draft

Finalize 1.99.8.0.0 release #444

wants to merge 326 commits into from

Conversation

RElesgoe
Copy link
Member

@RElesgoe RElesgoe commented Mar 3, 2021

No description provided.

…adder() because std::strncpy() may not null-terimate the destination string
… instead of connected packet in handle_bnet_packet()
…fore returning NULL in anongame_gameresult_parse()
cen1 and others added 12 commits March 15, 2021 20:43
This fixes an out-of-bounds access when recv() writes exactly 256 bytes into 'mybuf' and the subsequent code accesses or writes to the byte following the end of the 'mybuf' array.
Previously, the game speed code assumed that WC2 game speeds worked exactly like SC game speeds did. This commit recognizes 2 additional game speeds, "Even Slower" and "Even Faster".
…ore logging those values with eventlog() in both _client_authreq1() and _client_progident()
Upgrade d2dbs to use PvPGN's fdwatch networking API
@aperture147
Copy link

aperture147 commented Sep 1, 2021

It's 5 months now :( is this pull request still being active?

Signed-off-by: Dmitry Smirnov <[email protected]>
@onlyjob
Copy link

onlyjob commented Sep 14, 2021

Please do not commit common third party libraries like zlib, which is already shipped by all major GNU+Linux distributions.

See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

codespell: spelling corrections (to "develop" branch)
@RElesgoe
Copy link
Member Author

Please do not commit common third party libraries like zlib, which is already shipped by all major GNU+Linux distributions.

See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

These libraries were committed to facilitate easier compilation on Windows platforms where easy to use package managers do not exist.

Though, now that I'm checking the CMake code, I see that the condition for including the committed zlib is not guarded by the WIN32 variable (https://github.com/pvpgn/pvpgn-server/blob/develop/ConfigureChecks.cmake#L52-L55). This will need to be changed before merging this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants