Skip to content

Conversation

@kandersolar
Copy link
Member

@kandersolar kandersolar commented Oct 17, 2025

  • [ ] Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

I found a simple way to retrieve MERRA-2 data without needing extra dependencies like xarray and pydap (#1274). It is a little slow, but seems to work well otherwise.

Note, the tests should skip until I add the necessary credentials to the repository's secrets. credentials now added

@kandersolar kandersolar added this to the v0.13.2 milestone Oct 17, 2025
@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Oct 17, 2025
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test where the start/end dates have a timezone.

@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Oct 17, 2025
@IoannisSifnaios
Copy link
Contributor

IoannisSifnaios commented Oct 23, 2025

I guess you are maybe missing a "bad request" test? E.g., if username/password do not exist?

Otherwise LGTM! :-)

@kandersolar kandersolar added the io label Oct 28, 2025
@kandersolar kandersolar added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Nov 3, 2025

References
----------
.. [1] https://gmao.gsfc.nasa.gov/gmao-products/merra-2/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be links to the above three data sets here? I couldn't see how to get there from this link.

- M2T1NXRAD.5.12.4: SWGDN, SWGDNCLR, ALBEDO
- M2T1NXSLV.5.12.4: T2M, U10M, V10M, T2MDEW, PS, TO3, TQV
- M2T1NXAER.5.12.4: TOTEXTTAU, TOTSCATAU, TOTANGSTR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to include all these in the variable map? And make that visible in the documentation?

Also, if there is down-welling long-wave, please add it for module temperature modeling.

@adriesse
Copy link
Member

I found a simple way to retrieve MERRA-2 data without needing extra dependencies like xarray and pydap (#1274). It is a little slow, but seems to work well otherwise.

Is there anything worth describing about this technique? Is it a work-around of some sort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants