-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add function for accessing MERRA-2 #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AdamRJensen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a test where the start/end dates have a timezone.
|
I guess you are maybe missing a "bad request" test? E.g., if username/password do not exist? Otherwise LGTM! :-) |
|
|
||
| References | ||
| ---------- | ||
| .. [1] https://gmao.gsfc.nasa.gov/gmao-products/merra-2/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could there be links to the above three data sets here? I couldn't see how to get there from this link.
| - M2T1NXRAD.5.12.4: SWGDN, SWGDNCLR, ALBEDO | ||
| - M2T1NXSLV.5.12.4: T2M, U10M, V10M, T2MDEW, PS, TO3, TQV | ||
| - M2T1NXAER.5.12.4: TOTEXTTAU, TOTSCATAU, TOTANGSTR | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to include all these in the variable map? And make that visible in the documentation?
Also, if there is down-welling long-wave, please add it for module temperature modeling.
Is there anything worth describing about this technique? Is it a work-around of some sort? |
[ ] Closes #xxxxdocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.I found a simple way to retrieve MERRA-2 data without needing extra dependencies like xarray and pydap (#1274). It is a little slow, but seems to work well otherwise.
Note, the tests should skip until I add the necessary credentials to the repository's secrets.credentials now added