Skip to content

Remove deprecated pvsystem.sapm_spectral_loss #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 10 commits into from
Mar 14, 2025
Merged

Remove deprecated pvsystem.sapm_spectral_loss #2244

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4df4a93
remove from pvsystem.py and test_pvsystem.py
RDaxini Oct 8, 2024
f014473
remove from system_models.rst
RDaxini Mar 14, 2025
acd6191
Merge remote-tracking branch 'upstream/main' into remove_sapm_spectra…
RDaxini Mar 14, 2025
a68745a
Merge remote-tracking branch 'upstream/main' into remove_sapm_spectra…
RDaxini Mar 14, 2025
a98119e
Update v0.11.3.rst
RDaxini Mar 14, 2025
e962e90
slight wording change in whatsnew
RDaxini Mar 14, 2025
bfafe48
Update docs/sphinx/source/whatsnew/v0.11.3.rst
RDaxini Mar 14, 2025
020c250
add ! v0.6.1 and 10.0.0
RDaxini Mar 14, 2025
6f103e0
Merge branch 'remove_sapm_spectral_loss' of https://github.com/RDaxin…
RDaxini Mar 14, 2025
1a340e1
Merge branch 'main' into remove_sapm_spectral_loss
kandersolar Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/sphinx/source/reference/pv_modeling/system_models.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Sandia array performance model (SAPM)
pvsystem.sapm
pvsystem.sapm_effective_irradiance
pvsystem.sapm_spectral_loss
spectrum.spectral_factor_sapm
inverter.sandia
temperature.sapm_cell

Expand Down
2 changes: 2 additions & 0 deletions docs/sphinx/source/whatsnew/v0.11.3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ Breaking Changes
* Users must now provide ModelChain.spectral_model, or the 'no_loss' spectral
model is assumed. pvlib.modelchain.ModelChain no longer attempts to infer
the spectral model from PVSystem attributes. (:issue:`2017`, :pull:`2253`)
* Remove deprecated :py:func:`pvlib.pvsystem.sapm_spectral_loss`.
(:issue:`2243`, :pull:`2244`)

Bug fixes
~~~~~~~~~
Expand Down
6 changes: 0 additions & 6 deletions pvlib/pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2314,12 +2314,6 @@ def sapm(effective_irradiance, temp_cell, module):
return out


sapm_spectral_loss = deprecated(
since='0.10.0',
alternative='pvlib.spectrum.spectral_factor_sapm'
)(spectrum.spectral_factor_sapm)


def sapm_effective_irradiance(poa_direct, poa_diffuse, airmass_absolute, aoi,
module):
r"""
Expand Down
6 changes: 0 additions & 6 deletions tests/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,12 +234,6 @@ def test_PVSystem_multi_array_sapm(sapm_module_params):
system.sapm(500, temp_cell)


def test_sapm_spectral_loss_deprecated(sapm_module_params):
with pytest.warns(pvlibDeprecationWarning,
match='Use pvlib.spectrum.spectral_factor_sapm'):
pvsystem.sapm_spectral_loss(1, sapm_module_params)


def test_PVSystem_sapm_spectral_loss(sapm_module_params, mocker):
mocker.spy(spectrum, 'spectral_factor_sapm')
system = pvsystem.PVSystem(module_parameters=sapm_module_params)
Expand Down