Skip to content

removed kwargs in calcparams_desoto, calcparams_cec, and sapm #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wholmgren merged 5 commits into from
May 12, 2021
Merged

removed kwargs in calcparams_desoto, calcparams_cec, and sapm #1222

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
125e06a
removed kwargs in calcparams_desoto, calcparams_cec, and sapm
May 7, 2021
35bdcb5
updated whatsnew file
May 7, 2021
d5b97cd
update whatsnew file with PR number
May 7, 2021
545595d
moved note in whatsnew file
MichaelHopwood May 11, 2021
b71303c
Update v0.9.0.rst
MichaelHopwood May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/sphinx/source/whatsnew/v0.9.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ Bug fixes
* Update GFS product names for GFS v16. (:issue:`1202`, :pull:`1203`)
* Corrected methodology error in :py:func:`~pvlib.scaling.wvm`. Tracks with
fix in PVLib for MATLAB. (:issue:`1206`, :pull:`1213`)
* Removed the **kwargs parameters from :py:meth:`~pvlib.pvsystem.sapm` and
:py:meth:`~pvlib.pvsystem.calcparams_desoto` and
:py:meth:`~pvlib.pvsystem.calcparams_cec` (:issue:`1118`, :pull:`1222`)

Testing
~~~~~~~
Expand Down
15 changes: 3 additions & 12 deletions pvlib/pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ def get_iam(self, aoi, iam_model='physical'):
for array, aoi in zip(self.arrays, aoi))

@_unwrap_single_value
def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs):
def calcparams_desoto(self, effective_irradiance, temp_cell):
"""
Use the :py:func:`calcparams_desoto` function, the input
parameters and ``self.module_parameters`` to calculate the
Expand All @@ -393,9 +393,6 @@ def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs):
temp_cell : float or Series or tuple of float or Series
The average cell temperature of cells within a module in C.

**kwargs
See pvsystem.calcparams_desoto for details

Returns
-------
See pvsystem.calcparams_desoto for details
Expand All @@ -420,7 +417,7 @@ def calcparams_desoto(self, effective_irradiance, temp_cell, **kwargs):
)

@_unwrap_single_value
def calcparams_cec(self, effective_irradiance, temp_cell, **kwargs):
def calcparams_cec(self, effective_irradiance, temp_cell):
"""
Use the :py:func:`calcparams_cec` function, the input
parameters and ``self.module_parameters`` to calculate the
Expand All @@ -434,9 +431,6 @@ def calcparams_cec(self, effective_irradiance, temp_cell, **kwargs):
temp_cell : float or Series or tuple of float or Series
The average cell temperature of cells within a module in C.

**kwargs
See pvsystem.calcparams_cec for details

Returns
-------
See pvsystem.calcparams_cec for details
Expand Down Expand Up @@ -501,7 +495,7 @@ def calcparams_pvsyst(self, effective_irradiance, temp_cell):
)

@_unwrap_single_value
def sapm(self, effective_irradiance, temp_cell, **kwargs):
def sapm(self, effective_irradiance, temp_cell):
"""
Use the :py:func:`sapm` function, the input parameters,
and ``self.module_parameters`` to calculate
Expand All @@ -515,9 +509,6 @@ def sapm(self, effective_irradiance, temp_cell, **kwargs):
temp_cell : float or Series or tuple of float or Series
The average cell temperature of cells within a module in C.

kwargs
See pvsystem.sapm for details

Returns
-------
See pvsystem.sapm for details
Expand Down