-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a cumulative energy check functions #212
base: main
Are you sure you want to change the base?
Conversation
@qnguyen345 can we rename the 10004 file to system_10004_ac_energy.csv? This will make this a little more in-line with the naming conventions in the data folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first start! Made a couple of nitpicks in the docstrings and suggested updates to the main conversion function. Also we discussed adding an example to the example gallery.
- [ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.- [ ] Added new API functions todocs/api.rst
.in
docs/whatsnew
for all changes. Includes link to the GitHub Issue with
:issue:`num`
or this Pull Request with
:pull:`num`
. Includes contributor nameand/or GitHub username (link with
:ghuser:`user`
).I created an energy.py script in the quality folder to check and correct cumulative data streams. This is the github link to the original issue and discussion https://github.com/pvlib/pvanalytics/issues/165