Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a cumulative energy check functions #212

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

qnguyen345
Copy link
Contributor

@qnguyen345 qnguyen345 commented Aug 9, 2024

  • Closes Adding a cumulative energy check function #165
  • Added tests to cover all new or modified code.
    - [ ] Clearly documented all new API functions with PEP257 and numpydoc compliant docstrings.
    - [ ] Added new API functions to docs/api.rst.
  • Non-API functions clearly documented with docstrings or comments as necessary.
  • Adds description and name entries in the appropriate "what's new" file
    in docs/whatsnew
    for all changes. Includes link to the GitHub Issue with :issue:`num`
    or this Pull Request with :pull:`num`. Includes contributor name
    and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

I created an energy.py script in the quality folder to check and correct cumulative data streams. This is the github link to the original issue and discussion https://github.com/pvlib/pvanalytics/issues/165

@kperrynrel kperrynrel added the enhancement New feature or request label Aug 12, 2024
@kperrynrel kperrynrel added this to the v0.2.1 milestone Aug 12, 2024
@kperrynrel kperrynrel self-requested a review August 12, 2024 22:49
@kperrynrel
Copy link
Member

@qnguyen345 can we rename the 10004 file to system_10004_ac_energy.csv? This will make this a little more in-line with the naming conventions in the data folder.

Copy link
Member

@kperrynrel kperrynrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first start! Made a couple of nitpicks in the docstrings and suggested updates to the main conversion function. Also we discussed adding an example to the example gallery.

pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
pvanalytics/quality/energy.py Outdated Show resolved Hide resolved
@kandersolar kandersolar modified the milestones: v0.2.1, v0.2.2 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a cumulative energy check function
3 participants