Skip to content

Comments

Upgrade to Rails 6.1#2

Merged
pvalena merged 1 commit intopvalena:relaxfrom
jackorp:rails-upgrade
Nov 23, 2021
Merged

Upgrade to Rails 6.1#2
pvalena merged 1 commit intopvalena:relaxfrom
jackorp:rails-upgrade

Conversation

@jackorp
Copy link

@jackorp jackorp commented Nov 12, 2021

What works:
s2i build for Ruby 2.5...3.0

Running the container (bare in podman without DB && in podman with sqlite DB preinitialized).

Articles and comments work when using sqlite instead of PG.

What doesn't work: /

What I wasn't tested: That articles work with the Postgresql.

@jackorp
Copy link
Author

jackorp commented Nov 12, 2021

Copy link
Owner

@pvalena pvalena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pvalena
Copy link
Owner

pvalena commented Nov 15, 2021

Articles and comments work when using sqlite instead of PG.

What I wasn't tested: That articles work with the Postgresql.

@yselkowitz do you think this would be an issue?

@pvalena
Copy link
Owner

pvalena commented Nov 15, 2021

@jackorp where is the PostgreSQL / Sqlite setting?

@jackorp
Copy link
Author

jackorp commented Nov 15, 2021

@jackorp where is the PostgreSQL / Sqlite setting?

should be in config/database.yml, I did not touch that as I did not see a reason to.

(For testing I just copied test: sqlite config to production: and development)

@pvalena
Copy link
Owner

pvalena commented Nov 15, 2021

Works with s2i tests for Fedora: https://gist.github.com/jackorp/cf9c4a3b309493be7a02967ff8be0ab6

Can you test with 2.7 / 2.6 / 2.5 as well?

@jackorp
Copy link
Author

jackorp commented Nov 15, 2021

I'll fire the whole test suite now. It's going to take a while.

@jackorp
Copy link
Author

jackorp commented Nov 15, 2021

2.6 and 2.7 pass as well: https://gist.github.com/jackorp/2c3e98fb4750d49b92694304fa14846b

2.5 is not built anymore it seems.

@jackorp
Copy link
Author

jackorp commented Nov 15, 2021

JFTR: I did not explicitly test with Postgresql but I do not expect any failure or incompatibility.

Instead, I used SQLite for ease of setup & testing the app itself.

@pvalena
Copy link
Owner

pvalena commented Nov 23, 2021

I just noticed this goes into my PR. Let's go with this and figure out the status in the regular PR.

Thanks!

@pvalena pvalena merged commit 0bbe67d into pvalena:relax Nov 23, 2021
@yselkowitz yselkowitz mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants