-
Notifications
You must be signed in to change notification settings - Fork 2
Umsetzung Dokuverbesserungen (#29312) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
patrickdubios
commented
Sep 26, 2025
- Änderungen einiger Sätze
- Einbindung & Konfiguration des Markdown Linters "mado"
- Ergänzung von "just lint" um die Ausführung des Markdown Linters
- Änderungen einiger Sätze - Einbindung & Konfiguration des Markdown Linters "mado" - Ergänzung von "just lint" um die Ausführung des Markdown Linters
| mypy --check | ||
| cargo fmt --check | ||
| cargo clippy --all-targets --all-features -- --deny warnings | ||
| mado check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does 'mado' have an entrypoint like 'mado format' which we could add to the 'just format' command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I could find. If that is important, then we'd need to rely on another tool or develop one ourselves that reformats based on the rules we define in mado.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think it's fine this way. There are other lints as well (e.g. mypy) which do not have an automatic fix. You can just resolve this suggestion.
| "MD004", | ||
| "MD005", | ||
| "MD006", | ||
| # Ist etwas instabil bei nested lists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our public GitHub repositories are usually written in English entirely. Could you translate this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, looks great! I've just left a few comments above.
Additionally, you could translate the commit message to English. We usually use English only when working on our public GitHub repositories. It's also not necessary to add our internal ticket numbers to GitHub commit messages.