Skip to content

Conversation

@patrickdubios
Copy link
Contributor

  • Änderungen einiger Sätze
  • Einbindung & Konfiguration des Markdown Linters "mado"
  • Ergänzung von "just lint" um die Ausführung des Markdown Linters

- Änderungen einiger Sätze
- Einbindung & Konfiguration des
  Markdown Linters "mado"
- Ergänzung von "just lint" um die
  Ausführung des Markdown Linters
mypy --check
cargo fmt --check
cargo clippy --all-targets --all-features -- --deny warnings
mado check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 'mado' have an entrypoint like 'mado format' which we could add to the 'just format' command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I could find. If that is important, then we'd need to rely on another tool or develop one ourselves that reformats based on the rules we define in mado.toml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it's fine this way. There are other lints as well (e.g. mypy) which do not have an automatic fix. You can just resolve this suggestion.

"MD004",
"MD005",
"MD006",
# Ist etwas instabil bei nested lists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our public GitHub repositories are usually written in English entirely. Could you translate this one?

Copy link
Contributor

@florianschieder florianschieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks great! I've just left a few comments above.

Additionally, you could translate the commit message to English. We usually use English only when working on our public GitHub repositories. It's also not necessary to add our internal ticket numbers to GitHub commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants