lang: Add file function for reading files#365
Closed
aequitas wants to merge 2 commits intopurpleidea:masterfrom
Closed
lang: Add file function for reading files#365aequitas wants to merge 2 commits intopurpleidea:masterfrom
aequitas wants to merge 2 commits intopurpleidea:masterfrom
Conversation
aequitas
force-pushed
the
file_function
branch
3 times, most recently
from
5db478b to
0a400d6
Compare
aequitas
changed the title
purpleidea
reviewed
Feb 27, 2018
lang/funcs/core/file_func.go
Outdated
| import ( | ||
| "io/ioutil" | ||
|
|
||
| errwrap "github.com/pkg/errors" |
Owner
There was a problem hiding this comment.
third-party packages should be in third group at the end of imports
Contributor
Author
There was a problem hiding this comment.
this is what goimports makes of it, can we put this rule into a config file for goimports? I really don't want to be managing imports (and their sorting) by hand. A computer can do this just fine :)
Owner
There was a problem hiding this comment.
¯\_(ツ)_/¯
I thought it did do this. If not, it's a bug, missing feature, or a property not explicitly enforced.
It is the common approach we use here and in is seen in many other projects too.
aequitas
force-pushed
the
file_function
branch
17 times, most recently
from
760db57 to
010a2ba
Compare
aequitas
changed the title
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos: