Closed
Conversation
10 tasks
f-f
reviewed
Dec 19, 2019
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
Thanks for this! 🙂
This looks good, but I wouldn't like to use CPP, could we just move everything to the next version and remove the conditionals?
Contributor
|
Since this PR was raised Dhall 1.29 has been released, so it might be worth bumping to that while we're at it. @ijaketak I'm happy to lend a hand if you're busy! |
Member
|
@elliotdavies @ijaketak this is being superseded by #553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
First attempt.
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊