-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searching for deprecated libraries should return something #429
Comments
Thanks for the report. This behaviour was implemented on purpose originally, because in practice a lot of things from deprecated packages won’t work unless you go back to a version of the compiler that basically nobody is using any more. However it’s true that this is not always ideal; we shouldn’t assume that everyone is on the latest version of everything. I think we should still penalise results from deprecated packages quite heavily in the search ranking, but I am inclined to agree that removing them entirely is a bit heavy-handed. |
Thanks for looking at this If you still want to penalize deprecated modules in search
Also is it normal that search for readFloat and readFloat() behave differently, or is it a bug, because this played a big role in increasing my confusion |
It is expected that those behave differently: if the query is a valid PureScript type then the search will contain values whose types most closely match the query. |
Referring to the purescript book issue 259
search for readFloat returns nothing, because
Global
is deprecatedTo be more specific searching
which returns nothing
and the searching for
(I added the brackets thinking, maybe search only work on functions if you add brackets)
return a lot of irrelevant results
I think the search behavior should be more reasonable
And it should not return nothing
I think ideally it should return the correct result but clearly flag it as deprecated
The text was updated successfully, but these errors were encountered: