Skip to content

Drop deprecated foldMap1Default #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Drop deprecated foldMap1Default #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fba771
Drop deprecated foldMap1Default
JordanMartinez Mar 17, 2022
3feb79a
Add changelog entry
JordanMartinez Mar 17, 2022
7d1d15e
Fix imports
JordanMartinez Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Notable changes to this project are documented in this file. The format is based

Breaking changes:
- Migrate FFI to ES modules (#146 by @kl0tl and @JordanMartinez)
- Drop deprecated `foldMap1Default` (#147 by @JordanMartinez)

New features:

Expand Down
6 changes: 0 additions & 6 deletions src/Data/Semigroup/Foldable.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ module Data.Semigroup.Foldable
, foldl1Default
, foldMap1DefaultR
, foldMap1DefaultL
, foldMap1Default
, intercalate
, intercalateMap
, maximum
Expand All @@ -30,7 +29,6 @@ import Data.Newtype (ala, alaF)
import Data.Ord.Max (Max(..))
import Data.Ord.Min (Min(..))
import Data.Tuple (Tuple(..))
import Prim.TypeError (class Warn, Text)

-- | `Foldable1` represents data structures with a minimum of one element that can be _folded_.
-- |
Expand Down Expand Up @@ -81,10 +79,6 @@ foldMap1DefaultR f = map f >>> foldr1 (<>)
foldMap1DefaultL :: forall t m a. Foldable1 t => Functor t => Semigroup m => (a -> m) -> t a -> m
foldMap1DefaultL f = map f >>> foldl1 (<>)

-- | Deprecated previous name of `foldMap1DefaultL`.
foldMap1Default :: forall t m a. Warn (Text "'foldMap1Default' is deprecated, use 'foldMap1DefaultL' instead") => Foldable1 t => Functor t => Semigroup m => (a -> m) -> t a -> m
foldMap1Default = foldMap1DefaultL

instance foldableDual :: Foldable1 Dual where
foldr1 _ (Dual x) = x
foldl1 _ (Dual x) = x
Expand Down