Skip to content

Changelog updates since v4.1.1 #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Changelog updates since v4.1.1 #130

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4afc69f
Changelog updates since v4.1.1
milesfrain Jan 18, 2021
1f66ca7
fixups
milesfrain Jan 19, 2021
33f7fa9
fixups2
milesfrain Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,22 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes:
- Updated code for PureScript 0.14 (#120)
Copy link
Contributor

@hdgarrood hdgarrood Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clearer to phrase this as "Added support for PureScript 0.14, and dropped support for all previous versions"

- Removed `fold1Default` and deprecated `foldMap1Default` (#128)
Copy link
Contributor Author

@milesfrain milesfrain Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was the net result of breaking changes. Would be good to double-check.

Copy link
Member

@thomashoneyman thomashoneyman Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct


New features:
- Added `findMapWithIndex` (#119)
- Added `foldr1` `foldl1` `foldr1Default` `foldl1Default` `foldMap1DefaultR` `foldMap1DefaultL` (#121, #128)
Copy link
Contributor Author

@milesfrain milesfrain Jan 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the introduction, then removal of fold1DefaultR fold1DefaultL

Copy link
Member

@thomashoneyman thomashoneyman Jan 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be comma-separated, ie.

- Added `foldr1`, `foldl1`, ..., and `foldMap1DefaultL`

- Added `maximumBy` and `minimumBy` to `Data.Semigroup.Foldable` (#123)

Bugfixes:

Other improvements:
- Migrated CI to GitHub Actions and updated installation instructions to use Spago (#127)
- Added a CHANGELOG.md file and pull request template (#129 #130)
- Wrapped `traverseArrayImpl` IIFE in parentheses (#52)
- Added examples for `sequence` and `traverse` (#115)
- Changed `foldM` type signature to more closely match `foldl` (#111)

## [v4.1.1](https://github.com/purescript/purescript-foldable-traversable/releases/tag/v4.1.1) - 2018-11-23

Expand Down