Add maximumBy and minimumBy to Data.Semigroup.Foldable #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Oct 24, 2020
src/Data/Semigroup/Foldable.purs
Outdated
| maximum :: forall f a. Ord a => Foldable1 f => f a -> a | ||
| maximum = ala Max foldMap1 | ||
|
|
||
| maximumBy :: forall f a. Ord a => Foldable1 f => (a -> a -> Ordering) -> f a -> a |
There was a problem hiding this comment.
The Ord constraint is redundant here, right?
There was a problem hiding this comment.
I forgot to remove to remove the constraint after copying Data.Foldable.maximumBy and Data.Foldable.minimumBy 🤦
JordanMartinez
approved these changes
Oct 24, 2020
thomashoneyman
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This became possible with #121.