Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #30

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Update to v0.14.0-rc3 #30

merged 5 commits into from
Dec 4, 2020

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

This has a dependency on spec and mmorph.

@thomashoneyman
Copy link
Contributor

While not super fun, we can migrate this to use assert instead of spec in order to avoid having dependencies outside contrib:

https://github.com/purescript-contrib/purescript-unicode/blob/main/test/Test/Data/Char/Unicode.purs

I also don't see mmorph anywhere in the dependencies (including the downloaded packages in CI). I don't think that's actually a dependency.

@JordanMartinez
Copy link
Contributor Author

I worked around the tests issue. How's this?

thomashoneyman
thomashoneyman approved these changes Dec 3, 2020
View reviewed changes
test/Test/Data/Char/Unicode.purs Outdated
Comment on lines 18 to 19
-- import Test.Spec (Spec, describe, it)
-- import Test.Spec.Assertions (shouldEqual)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- import Test.Spec (Spec, describe, it)
-- import Test.Spec.Assertions (shouldEqual)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit fixing this.

@JordanMartinez JordanMartinez merged commit a67079a into purescript-contrib:main Dec 4, 2020
@JordanMartinez JordanMartinez deleted the updateTo14 branch December 4, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman