Add roles declarations to allow safe coercions #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl0tl
force-pushed
the
roles-declarations
branch
from
4433ef0 to
36cbd49
Compare
|
This should build now, but might need to be rebased on top of current |
kl0tl
force-pushed
the
roles-declarations
branch
from
36cbd49 to
fbd7cb5
Compare
JordanMartinez
approved these changes
Dec 5, 2020
thomashoneyman
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows terms of type
ReactThis props state,ReactClass props,Ref a,RefHandler aandSyntheticEvent_ eventto be coerced to typeReactThis props' state',ReactClass props',Ref b,RefHandler bandSyntheticEvent_ event'whenCoercible props props',Coercible state state',Coercible a bandCoercible event event'hold, hence allowing the zero costcoerceto introduce and eliminate newtypes in components props and state, refs and their handlers and synthetic events for instance.