Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #46

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Update to v0.14.0-rc3 #46

merged 5 commits into from
Dec 3, 2020

Conversation

JordanMartinez
Copy link
Contributor

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 2, 2020
@JordanMartinez
Copy link
Contributor Author

Hm... I can't merge this PR? Why?

@thomashoneyman thomashoneyman merged commit 5e79e56 into purescript-contrib:main Dec 3, 2020
@JordanMartinez
Copy link
Contributor Author

Slight problem here...

Should we be removing the MonadZero instance? The class was deprecated, not fully removed. So I believe we shouldn't be removing it here. However, that creates problems for CI because the warning will always be emitted.

@thomashoneyman
Copy link
Contributor

I've created some discussions around that:

I'm not sure what the policy will be as far as core goes, but I think it's reasonable to remove instances of this class in contrib libraries. That said, I'm happy to wait on these discussions before removing any more instances, and we can revert that change in this library if needed. After all, the main branch is frozen and we can add subsequent commits.

@JordanMartinez JordanMartinez deleted the updateTo14 branch December 3, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman