-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v0.14.0-rc3 #20
Update to v0.14.0-rc3 #20
Conversation
I'm getting two errors here. The first is likely a dependency issue in the
|
This library basically wraps
either way, I don't think we need the dependency on |
I say we go ahead and make a tiny |
I don't think the issue is making that repo. It was my understanding that creating the |
That's right, we can put it in |
Yeah. Please do! |
I guess my preference would be to implement the URI codec functions without specifically relying on the FFI functions, as then we're not forcing a dependency on the JS runtime, and we could also make them not terrible 😉... but maybe that's out of scope for now. |
I can't approve this PR because I opened it, but I approve Thomas' commit that fixes the dependency issue. If someone else wants to approve this, we can get it merged. |
Backlinking to purescript-contrib/governance#35