-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaping fix + test suite #44
Conversation
I'm on mobile, which doesn't show when or how this got marked as ready for review, and I can't change it back. But just to be sure, it's not ready yet, I'll request review when it is. |
@jonascarpay No problem, I switched it back to draft for you. |
ccbcd05
to
ccaa6b0
Compare
ccaa6b0
to
c4b874a
Compare
c4b874a
to
f29c014
Compare
data TestCase | ||
data Result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it really matters for this PR, but I thought you might be interested that it seems like PureScript people like to use empty data types for things like Void
, but use foreign import data
for things that are coming from FFI:
After some offline discussion, we decided that the test suite needs a better design before being worth merging. The issue with this test suite is that, while it looks like a suite of unit tests, it acts more like an integration test. Put differently, the most interesting part about it isn't that it passes all the tests, but that it runs at all. Either we acknowledge that and have a design that better communicates that fact, or we need to find a way of better isolating the guarantees that we want our test suite to provide. |
hi @jonascarpay |
@thought2 Oh wow, that's a very good catch! Please open a separate issue, and I'll have a think how to best go about fixing it. I guess that with our strings passing through Nix, PureScript, Haskell (and arguably Bash) just using |
Fixes #35
Fixes #5
This PR contains a rudimentary test suite, as well as a fix for the escaping issue.
Don't actually justthe more I think about it the more I think this is fineshow
in Haskellrun