Advanced JavaScript Topics Workshop

[maneesht]

No description provided.

[redixhumayun]

@maneesht Hey, I was wondering if you could take a look at an issue I was having the calculator. So, it seems like when Babel transpiles ES2015 to ES5, it doesn't support CommonJS import and export statements. I uploaded the code with the bug to the calculator branch if you want to take a look at it.

Here is a SO thread for reference to the issue I am talking about. https://stackoverflow.com/questions/29434978/babel-generated-code-causes-error-exports-is-undefined

It seems like the solution would be to use a bundler like webpack, so do you want to do that? I don't think the students would know how to go about configuring webpack by this point would they?

Alternatively, if there is a simpler way to work around this or I've just missed something, let me know and I'll fix it.

[redixhumayun]

Just wanted to add - there might be a simple workaround here (https://babeljs.io/docs/plugins/transform-es2015-modules-commonjs/). I haven't tried it yet, I'll get to it tomorrow.

[maneesht]

I think your options are:

1. Transform to systemJS
2. Using a module bundler like webpack
3. Don't use modules
   I like option 3 since it has the least complexity, but it's up to you to choose and we can discuss from there

[maneesht]

Also, can you adhere to the linting?

[redixhumayun]

Option 3 sounds good to me. It might make the code messy, but that's just something to deal with.

And by linting, do you mean just running the code through ESLint?

[maneesht]

Yes. I believe I have an eslintrc

…

On Tue, Jul 25, 2017, 10:20 PM Zaid Humayun ***@***.***> wrote: Option 3 sounds good to me. It might make the code messy, but that's just something to deal with. And by linting, do you mean just running the code through ESLint? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFJyQqJKkSvXIFmQ7CqSQScbBuz0TKSrks5sRsyOgaJpZM4OX4gN> .