Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(maint) Fix for ABS PR#306 that includes json responses #99

Merged
merged 2 commits into from
Sep 22, 2020
Merged

(maint) Fix for ABS PR#306 that includes json responses #99

merged 2 commits into from
Sep 22, 2020

Conversation

sbeaulie
Copy link
Contributor

@sbeaulie sbeaulie commented Sep 21, 2020 •
edited
Loading

Status

[Ready for Merge]

Description

Before this change ABS sometimes returned a string of JSON with escaped
quotes, that had to be parsed again
With this change, floaty should accept both the legacy and the new
full JSON responses.

Related Issues

Todos

  • Tests
  • Documentation

Reviewers

@puppetlabs/dio
@highb
@briancain

(maint) Fix for ABS PR#306 that includes json responses
4df970b 
Before this change ABS sometiimes returned a string of JSON with escaped
quotes, that had to be parsed again
With this change, floaty should accept both the legacy and the new
full JSON responses.
@sbeaulie sbeaulie requested review from briancain, highb and a team as code owners September 21, 2020 19:48
genebean
genebean previously approved these changes Sep 21, 2020
View reviewed changes
@genebean genebean self-requested a review September 21, 2020 20:02
@genebean genebean dismissed their stale review September 21, 2020 20:03

more work incoming per slack chat

@sbeaulie
Copy link
Contributor Author

Added unit tests for the list command in ABS, with both legacy and new response.

tested in dev:

~/workspace/vmfloaty >> master $ ./bin/floaty list
error: no implicit conversion of Array into String. Use --trace to view backtrace
 ✘ ~/workspace/vmfloaty >> master $ git checkout fix-returned-abs-json
Switched to branch 'fix-returned-abs-json'
 ~/workspace/vmfloaty >> fix-returned-abs-json $ ./bin/floaty list
*** VMPOOLER Pools ***

*** VMPOOLER ONDEMAND Pools ***

@justinstoller

@genebean
Copy link
Contributor

FYI @highb, @briancain, and anyone else watching - barring objections, I plan to merge this tomorrow morning and then cut a release.

highb
highb approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense to me. :shipit:

@genebean genebean merged commit 013325b into master Sep 22, 2020
@genebean genebean deleted the fix-returned-abs-json branch September 22, 2020 12:57
@genebean genebean mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highb highb highb approved these changes

@genebean genebean genebean approved these changes

@briancain briancain Awaiting requested review from briancain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbeaulie @genebean @highb