Add Dependabot and Coveralls #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancain
suggested changes
Jul 2, 2020
|
Do not merge until #69 is approved and merged |
genebean
force-pushed
the
tools
branch
5 times, most recently
from
ab4ade0
to
75dce76
Compare
|
Rebased post merging of #69 |
briancain
previously approved these changes
Jul 2, 2020
|
@highb I think because of overlapping roles this is stuck waiting on your approval too. (we may also need to adjust the way the codeowners stuff is defined) |
|
Actually, I just figured out the problem... fixing codeowners now |
This adds Dependabot to keep things updated and Coveralls so we can see how code coverage changes over time. Coveralls / SimpleCov are configured so that both the SimpleCov html report and the Coveralls report are generated. This facilitates easily seeing coverage locally in addtion to via CI.
|
Fixed duplicate testing by removing unneeded webhook integration and by updating travis to only build PR |
|
This PR was previously approved but rebasing busted the reviews. Merging anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Dependabot to keep things updated and Coveralls so we can see how code coverage changes over time. Coveralls / SimpleCov are configured so that both the SimpleCov html report and the Coveralls report are generated. This facilitates easily seeing coverage locally in addtion to via CI.
This PR builds on the code in #69