Add support for vmpooler on demand provisioning

[mattkirby]

Status

Ready for Merge

Description

Add support for on demand provisioning via pooler. Add a capability to list ondemand pools in ABS. Add a dockerfile to improve local development.

Related Issues

https://tickets.puppetlabs.com/browse/POOLER-158

Todos

• Documentation

Reviewers

@highb
@briancain

[highb]

@mattkirby Looks like there's some linter issues that need fixing:

$ bundle exec rake rubocop spec
Running RuboCop...
.rubocop_todo.yml: Metrics/LineLength has the wrong namespace - should be Layout
The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file:
 - Layout/EmptyLinesAroundAttributeAccessor (0.83)
 - Layout/SpaceAroundMethodCallOperator (0.82)
 - Lint/DeprecatedOpenSSLConstant (0.84)
 - Lint/MixedRegexpCaptureTypes (0.85)
 - Lint/RaiseException (0.81)
 - Lint/StructNewOverride (0.81)
 - Style/ExponentialNotation (0.82)
 - Style/HashEachMethods (0.80)
 - Style/HashTransformKeys (0.80)
 - Style/HashTransformValues (0.80)
 - Style/RedundantFetchBlock (0.86)
 - Style/RedundantRegexpCharacterClass (0.85)
 - Style/RedundantRegexpEscape (0.85)
 - Style/SlicingWithRange (0.83)
For more information: https://docs.rubocop.org/rubocop/versioning.html
Inspecting 26 files
...C......C..C............
Offenses:
lib/vmfloaty.rb:17:1: C: Metrics/ClassLength: Class has too many lines. [396/394]
class Vmfloaty ...
^^^^^^^^^^^^^^
lib/vmfloaty.rb:20:3: C: Metrics/CyclomaticComplexity: Cyclomatic complexity for run is too high. [65/55]
  def run # rubocop:disable Metrics/AbcSize ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/vmfloaty.rb:20:3: C: Metrics/MethodLength: Method has too many lines. [393/391]
  def run # rubocop:disable Metrics/AbcSize ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/vmfloaty.rb:20:3: C: Metrics/PerceivedComplexity: Perceived complexity for run is too high. [66/63]
  def run # rubocop:disable Metrics/AbcSize ...
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/vmfloaty/pooler.rb:53:7: C: Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
      raise "HTTP #{response.status}: Failed to obtain VMs from the pooler at #{url}/vm/#{os_string}. #{res_body}" unless ondemand
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/vmfloaty/pooler.rb:66:17: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
    STDOUT.puts "The request has been fulfilled"
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/vmfloaty/utils.rb:49:62: C: Style/MultipleComparison: Avoid comparing a variable with multiple items in a conditional, use Array#include? instead.
    filtered_response_body = response_body.reject { |key, _| key == 'request_id' || key == 'ready' }
                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
26 files inspected, 7 offenses detected
RuboCop failed!
The command "bundle exec rake rubocop spec" exited with 1.
Done. Your build exited with 1.

[briancain]

@mattkirby - Since I believe @highb 's last day at Puppet is today...it would be good to find some internal maintainer at puppet that's not me for this, since I have no access to test any of the changes :D Currently the repo is setup with github actions to release gems on merge, so at least that part is automated away. I'm happy to add you or someone else that makes sense for reviewing PRs.

[briancain]

Actually, it looks like I was finally able to transfer ownership of this repo to puppetlabs!

[briancain]

Thanks @codyclements @highb for making that happen.

[highb]

Making sure to add myself as a maintainer so I can help out in the future, as well. 😉

[mattkirby]

I have updated this to address the feedback. Please let me know if this needs further changes.

[highb]

👋 Looks good to me!

[highb]

Look at my approval above, it looks like I no longer have write access on the repo? That's unfortunate.

Need to add the feature to vmfloaty to meet a timeilne for a vmpooler application change. Will make the requested change in a subsequent PR if requested.

[mattkirby]

Look at my approval above, it looks like I no longer have write access on the repo? That's unfortunate.

@highb not sure why, but I have updated it to add you as a maintainer on the repo. I think you should have an invite. Let me know if it does not work for some reason.

[highb]

Yep, that worked! Thank you.