SSH Command respects ABS now and tests should fail if the API changes… #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkergimenez
force-pushed
the
fix_ssh_command_breaking
branch
from
3ca0b11
to
ac14629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… again
Proof
❰mikker❙~/Dev/vmfloaty(git:fix_ssh_command_breaking)❱✔≻ bin/floaty ssh ubuntu-1604-x86_64 --trace --service vmpooler
The authenticity of host 'blocky-armor.delivery.puppetlabs.net (10.16.115.120)' can't be established.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'blocky-armor.delivery.puppetlabs.net,10.16.115.120' (ECDSA) to the list of known hosts.
[email protected]'s password:
❰mikker❙~/Dev/vmfloaty(git:fix_ssh_command_breaking)❱✘≻ bin/floaty ssh ubuntu-1604-x86_64 --trace --service abs
Requesting VMs with job_id: 1580167494644. Will retry for up to an hour.
Waiting 1 seconds to check if ABS request has been filled. Queue Position: 144... (x1)
Waiting 2 seconds to check if ABS request has been filled. Queue Position: 144... (x2)
Waiting 3 seconds to check if ABS request has been filled. Queue Position: 143... (x3)
The authenticity of host 'close-poison.delivery.puppetlabs.net (10.16.118.16)' can't be established.
Are you sure you want to continue connecting (yes/no)? no
Status
Ready for Merge
Description
The SSH Command was broken because the vmpooler api changed but it wasn't changed in the ssh command. This PR:
Related Issues
Todos
Reviewers
@demophoon
@briancain