ABS will sometimes return null values in the /status/queue endpoint #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkergimenez
force-pushed
the
check_for_blank_lines_returned_from_abs_status_queue
branch
2 times, most recently
from
6f2a82c
to
14a9b9e
Compare
mikkergimenez
force-pushed
the
check_for_blank_lines_returned_from_abs_status_queue
branch
from
14a9b9e
to
2c456f1
Compare
highb
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for Merge
Description
Fix a bug where ABS will sometimes return null values on the /status/queue endpoint and floaty was not catching that.
Related Issues
Todos
Reviewers
@demophoon
@briancain