Rubocop cleanup

[rodjek]

Status

Ready for Merge

Description

Cleans up the rubocop problems using almost the default configuration. The customisations ensure cleaner diffs when changing multiline arrays, hashes & method calls and the use of the 1.8 hash syntax to keep the style consistent regardless of what the keys are.

The metrics cops have been left in the todo config as those would require substantial refactoring to fix and would be best handled in separate PRs (if it all).

Reviewers

@demophoon
@briancain

[briancain]

👍 looks good to me. I can't really test everything here as the dev vmpooler can only do so much :) So I'm trusting if you have access to the production vmpooler, you have tested the changes!'

Thanks again for the fixups! 🎉