Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commander version to clear up deprecation warnings #46

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Bump commander version to clear up deprecation warnings #46

merged 1 commit into from
Oct 24, 2017

Conversation

highb
Copy link
Contributor

@highb highb commented Oct 18, 2017

Getting warnings with commander 4.3.0:

floaty get centos-7-x86_64
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333: warning: constant ::NIL is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333: warning: constant ::TRUE is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333: warning: constant ::FALSE is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333: warning: constant ::Fixnum is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333: warning: constant ::Bignum is deprecated
- as9r7rigltr70zt.delivery.puppetlabs.net (centos-7-x86_64)

Bumping the version to the latest, 4.4.3, seems to clear them up.

This commit bumps the commander version up to 4.4.3 in order to clear
up the deprecation warnings being emitted from 4.3.0:
```
> floaty get centos-7-x86_64
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333:
warning: constant ::NIL is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333:
warning: constant ::TRUE is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333:
warning: constant ::FALSE is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333:
warning: constant ::Fixnum is deprecated
/Users/highb/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/commander-4.3.8/lib/commander/user_interaction.rb:333:
warning: constant ::Bignum is deprecated
- as9r7rigltr70zt.delivery.puppetlabs.net (centos-7-x86_64)
```
Copy link
Contributor

@briancain briancain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@briancain
Copy link
Contributor

I'll try to cut another release this week, should be straight forward. :)

@briancain briancain merged commit 53eb14a into puppetlabs:master Oct 24, 2017
@briancain
Copy link
Contributor

Actually JK I had some time now....it should be fixed via 0.8.1! Thanks :)

@highb
Copy link
Contributor Author

highb commented Oct 24, 2017

💥 😎 🎸 💥

@highb highb deleted the bump_commander_version branch October 24, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants