Developersdevelopersdevelopers #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mckern
commented
Mar 1, 2017
mckern
commented
Formatting is slightly more idiomatic now.
|
I think Travis is going to throw up on Ruby 2.3 and/or 2.4. The problem isn't the library, it's the tests. Investigating when I can get a straight answer out of Travis. |
As per https://opensource.org/licenses/alphabetical, the name should be Apache-2.0, not Apache.
Pessimistic versioning means that Faraday 0.11.0 will be installed if the constraint is "~> 0.9", and that will break spec tests due to newer restrictions in Faraday around how HTTP requests are handled by rspec. We don't want to break tests.
Instead of having a hardcoded version identifier in multiple locations, we can leverage the Classname::VERSION pattern to have a single canonical version number that everything can reference programmatically.
briancain
reviewed
Mar 1, 2017
| @@ -16,7 +16,7 @@ class Vmfloaty | |||
| include Commander::Methods | |||
|
|
|||
| def run | |||
| program :version, Version.get | |||
| program :version, Vmfloaty::VERSION | |||
There was a problem hiding this comment.
Cool, haven't tried this yet but I've tried to get this to work this way for a couple of times now and it never seems to behave correctly. 👍
|
Oh my, it seems like I'm going to be arrested from all of these offenses Haha....looks like I have some cleanup to do. This all looks great to me though! 👍 once Travis decides to cooperate. |
|
I have a Rubocop PR pending too. |
Ruby 2.0 is dead, but 2.1 is not. Of note is that Ruby 2.1 *will* be unsupported soon, but it's definitely not dead yet.
|
LOOKS GOOD 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.