Show tag values in list --active
#23
Conversation
| @@ -31,4 +31,61 @@ | |||
| expect(Utils.generate_os_hash(host_arg)).to be_empty | |||
| end | |||
| end | |||
|
|
|||
| describe '#prettyprint_hosts' do | |||
There was a problem hiding this comment.
There's some benefit here in specifying the desired output format, but honestly this test is going to be super brittle, so I don't know if it - cost vs benefit wise - is going to be very valuable. Happy to remove it, I just didn't feel like I could submit a patch without a test around the change.
There was a problem hiding this comment.
Yeah....I feel like that's fine for the most part. I'm not too experienced in webmock unit tests checking stdout from puts but I feel like it should be ok? Is it brittle just because the moment someone changes how the prettyprint hosts method works it'll break? or because there's the potential for other things to appear in stdout while running unit tests?
There was a problem hiding this comment.
Cool. I agree its probably fine, though brittle for those reasons. Thanks!
|
@justinstoller thanks! I'll check this out tomorrow. Looks good otherwise, also woo tests! |
|
Woo! Looks good to me: If you don't mind, it would be great if you'd squash the commits down like you mentioned! And then I'd be happy to merge :) 👍 |
justinstoller
changed the title
list --activelist --active
If tags exist this will add them as comma-space separated list of {key}: {value} pairs after the currently listed metadata. If there aren't tags for the vm there should be no change to the output.
I enable travis on my fork and tested out a couple different combinations. You can see my version of this PR here: justinstoller#1 Hopefully that info is helpful?