Require force flag for pool requests larger than 5? #40
Comments
briancain
added a commit
that referenced
this issue
Dec 9, 2016
Prior to this commit, a user could easily steam roll vmpooler by accidentally adding an extra digit to their get request: $ floaty get centos=100 Accidentially hitting enter on this would completely drain a centos pool. This commit updates that bevaior to force users to use the --force flag if they really want to get more than 5 vms per template. 5 was choosen because most vm pools at Puppet were in the 5-10 range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A lot of vmpooler pools max out at the 5-10 range. It's really easy to accidentally request the entire pool if you add an extra digit and hit enter. For example:
In this case, I only wanted 10, but I accidentally added a 0 making the request 100. Since floaty immediately makes that HTTP request, its now completely drained the pool. Vmfloaty should have some safeguards around this to make sure people really want that many vms.
The text was updated successfully, but these errors were encountered: