(maint) Fix path for pxp-agent using new Windows MSI layout #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shrug this is required for the new Windows MSI layout. @james-stocks can you take a look and merge this asap? |
The Windows MSI layout changed to sharing binaries for C++ applications. That means pxp-agent.exe now relies on files in puppet/bin. Update the test to include that in PATH. For now hard-code in the test. It's not trivial to amend the privatebindir in config/aio/options.rb, since the setting is platform-dependent. This might eventually live in Beaker, but since it's only needed for this test that may not be worth it. [skip ci]
MikaelSmith
force-pushed
the
fix-agent-path
branch
from
de77813
to
c7ef0d3
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows MSI layout changed to sharing binaries for C++ applications.
That means pxp-agent.exe now relies on files in puppet/bin. Update the
test to include that in PATH.
For now hard-code in the test. It's not trivial to amend the
privatebindir in config/aio/options.rb, since the setting is
platform-dependent. This might eventually live in Beaker, but since it's
only needed for this test that may not be worth it.