(maint) Enable builds with static cpp-pcp-client #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, Leatherman's logging/locale libraries need to be contained in the same DLL. That can be done by either making them shared libraries, or by creating a monolithic pxp-agent binary. Currently our packaging makes it messy to use shared Leatherman DLLs, and they don't bring us any advantages. Make it simple to use cpp-pcp-client as a static library instead so we can produce a smaller package.
|
LGTM |
| @@ -54,6 +54,12 @@ set (LIBS | |||
| ${LEATHERMAN_LIBRARIES} | |||
| ) | |||
|
|
|||
| if (WIN32) | |||
| # Necessary when statically linking cpp-pcp-client on Windows. | |||
| # Shouldn't hurt when cpp-pcp-client is a DLL. | |||
There was a problem hiding this comment.
Can't we just test what kind of cpp-pcp-client library we are linking against? Whether static or shared?
There was a problem hiding this comment.
I'm not sure there's a way to tell from here. /cc @branan
I could add a CMake config file to the cpp-pcp-client project that gets installed, and would replace the Findcpp-pcp-client script in this project. That would include link dependencies and whether it's static or dynamic. However there's pretty much no downside with linking an extra system library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, Leatherman's logging/locale libraries need to be contained in
the same DLL. That can be done by either making them shared libraries, or
by creating a monolithic pxp-agent binary.
Currently our packaging makes it messy to use shared Leatherman DLLs, and
they don't bring us any advantages. Make it simple to use cpp-pcp-client
as a static library instead so we can produce a smaller package.