(PCP-293 & PCP-294) #334
Merged
(PCP-293 & PCP-294) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2016 17:40
Due to PCP-294, the acceptance tests might message pcp-broker before it has fully started. This commit changes the pre-suite to use the master ref for pcp-broker (PCP-250 being fixed allows this); and changes the helper methods so pcp-broker is queried for its running state. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the reconnect_after_broker_unavailable.rb acceptance test failing CI on master
PCP-293 - bring the test over to stable; it should not have been only on master
PCP-294 - Workaround for PCP-294, when the pcp-broker port becomes available; query pcp-broker for its state, and do not continue with the test until it reports "running"