(maint) Acceptance tests should accept SHA as environment variable #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 13, 2015 16:43
Our main build pipeline uses environment variable SUITE_COMMIT to store the SHA of Puppet Agent to fetch and test. To re-use our tests in the Puppet Agent nightly pipeline, the environment variable SHA should be used instead. This commit supports either during acceptance test setup.
Move the check (and possible fail) if a SHA is not provided in ENV to Rakefile. This will have the job fail immediately without starting test code.
johnduarte
pushed a commit
that referenced
this pull request
Nov 13, 2015
(maint) Acceptance tests should accept SHA as environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.