Skip to content

Conversation

nabertrand
Copy link

On systems with a git version too old to support the GIT_SSH_COMMAND, a git wrapper script is created in the default temp directory. If that filesystem is mounted noexec, git is unable to execute the wrapper script:

Error: Execution of 'git clone [email protected]:org/repo.git /repo_dir' returned 128: Cloning into '/repo_dir'...
fatal: cannot exec '/tmp/git-helper20230607-525-1fvzyp1': Permission denied

This was solved in 7f97a76 by using the Puppet statedir instead of the default temp directory, but this was later reverted in 6842002.

This PR enables specifying the directory used for the wrapper script.

@nabertrand nabertrand requested a review from a team as a code owner June 12, 2023 21:39
Copy link

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 6462c93 into puppetlabs:main Jun 28, 2023
@lihu-zhong lihu-zhong mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants