Skip to content

(CAT-1351) - Fixing linting issue #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ramesh7 wants to merge 1 commit into from
Closed

(CAT-1351) - Fixing linting issue #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
if ($manage_default_ca_cert) and ($facts['os']['family'] == 'RedHat') {
exec { 'download_install_katello_cert_rpm':
path => ['/usr/bin', '/bin',],
command => "curl -k -o /tmp/katello-ca-consumer-latest.noarch.rpm ${satellite_url}/pub/katello-ca-consumer-latest.noarch.rpm && yum -y install /tmp/katello-ca-consumer-latest.noarch.rpm", # rubocop:disable Layout/LineLength
command => ['curl', '-k', '-o', '/tmp/katello-ca-consumer-latest.noarch.rpm', "${satellite_url}/pub/katello-ca-consumer-latest.noarch.rpm", '&&', 'yum', '-y', 'install', '/tmp/katello-ca-consumer-latest.noarch.rpm'], # rubocop:disable Layout/LineLength
Copy link

@ekohl ekohl Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't valid because it uses shell (see the &&). It can't be safely done this way.

You can split it in a file resource with ${satellite_url}/pub/katello-ca-consumer-latest.noarch.rpm" as the source and then notify a package resource, but you'll always have some intermediate file on disk.

creates => '/etc/rhsm/ca/katello-server-ca.pem',
}

Expand Down