-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix log directory config entry name #1457
Conversation
it does not satisfy the name regex and thus breaks the puppet run, if the log dir is set
|
@chillinger thanks for the patch. Can you explain where it failed? The tests passed in the past so probably a test is missing somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like I forgot to make this uniform, the title is just missing the underscores and this will break the regex.
EDIT: can you please add the following: key => 'log_directory',
@chillinger please sign the CLA
@SimonHoenscheid CLA is signed could you please clarify where to spcify |
nvm, just realized what you meant |
@SimonHoenscheid somehow the CLA bot doesn't transfer the correct status - the CLA is signed |
it does not satisfy the name regex and thus breaks the puppet run, if the log dir is set
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
configure logdir parameter of postgresql::globals - puppet run breaks
the naming of the parameter is wrong and contains spaces
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply
)