Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log directory config entry name #1457

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Conversation

chillinger
Copy link

it does not satisfy the name regex and thus breaks the puppet run, if the log dir is set

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • [/] Root cause and the steps to reproduce. (If applicable)
    configure logdir parameter of postgresql::globals - puppet run breaks
  • [/] Thought process behind the implementation.
    the naming of the parameter is wrong and contains spaces

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • [/] Manually verified. (For example puppet apply)

it does not satisfy the name regex and thus breaks the puppet run, if the log dir is set
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bastelfreak
Copy link
Collaborator

@chillinger thanks for the patch. Can you explain where it failed? The tests passed in the past so probably a test is missing somewhere.

SimonHoenscheid
SimonHoenscheid previously approved these changes Jul 5, 2023
Copy link
Collaborator

@SimonHoenscheid SimonHoenscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I forgot to make this uniform, the title is just missing the underscores and this will break the regex.
EDIT: can you please add the following: key => 'log_directory',

@chillinger please sign the CLA

@SimonHoenscheid SimonHoenscheid self-requested a review July 5, 2023 08:21
@SimonHoenscheid SimonHoenscheid dismissed their stale review July 5, 2023 08:22

changes needed

@chillinger
Copy link
Author

@SimonHoenscheid CLA is signed

could you please clarify where to spcify
key => 'log_directory',
?

@chillinger
Copy link
Author

nvm, just realized what you meant

@chillinger
Copy link
Author

@SimonHoenscheid somehow the CLA bot doesn't transfer the correct status - the CLA is signed

@chelnak chelnak merged commit 11a4d35 into puppetlabs:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants