Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REPLATS-487) Add plan to install helm charts #12

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

jpartlow
Copy link
Collaborator

Generic plan for installing helm charts that handles adding a local helm
repository first, if required, and waiting for the deployments and
statefulsets to rollout if a selector is specified.

@jpartlow jpartlow force-pushed the replats-487-add-plan-to-install-helm-charts branch from 737b340 to ccfe34d Compare December 15, 2021 21:45
@jpartlow jpartlow marked this pull request as ready for review December 15, 2021 21:51
@jpartlow jpartlow requested a review from a team as a code owner December 15, 2021 21:51
Generic plan for installing helm charts that handles adding a local helm
repository first, if required, and waiting for the deployments and
statefulsets to rollout if a selector is specified.
@jpartlow jpartlow force-pushed the replats-487-add-plan-to-install-helm-charts branch from ccfe34d to 9204fc1 Compare December 15, 2021 22:42
* [`targets`](#targets)
* [`chart_name`](#chart_name)
* [`release`](#release)
* [`repository_uri`](#repository_uri)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking this seems to take you to the repository_uri under "helm_add_repository" instead of "pam_tools::install_chart".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like a puppet-strings bug.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should clarify; REFERENCE.md is generated by rake strings:generate:reference which is a puppet-strings rake helper. If I manually edit for these issues, it will come into conflict or be reset the next time REFERENCE gets auto generated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like puppet-strings is using github issues; I'll open a bug there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* [`release`](#release)
* [`repository_uri`](#repository_uri)
* [`values_yaml`](#values_yaml)
* [`namespace`](#namespace)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, this link seems to go to the namespace under "helm_install_chart".

* [`values_yaml`](#values_yaml)
* [`namespace`](#namespace)
* [`part_of`](#part_of)
* [`timeout`](#timeout)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one goes to "get_ingress_ip"

Copy link

@abottchen abottchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that stands out to me are the puppet strings related link oddities.

These weren't displaying properly as code in the REFERENCE.md.
@jpartlow jpartlow force-pushed the replats-487-add-plan-to-install-helm-charts branch from af310da to da8d7ac Compare December 16, 2021 00:46
@jpartlow jpartlow merged commit 67b45bf into main Dec 16, 2021
@jpartlow jpartlow deleted the replats-487-add-plan-to-install-helm-charts branch December 16, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants