(CONT-1048) - Removal of deprecated node_encrypt::file defined type #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
changed the title
jordanbreen28
pushed a commit
that referenced
this pull request
Jun 8, 2023
Skipping this test due to a difference in behaviour between mocha stub and rspec allow when calling the PuppetX::Binford2k::NodeEncrypt.decrypt method on Ruby 2.x only. Voted by the team to skip, as test case will be removed in #94 with the removal of the deprecated node_encrypt::file defined type.
jordanbreen28
pushed a commit
that referenced
this pull request
Jun 8, 2023
Skipping this test due to a difference in behaviour between mocha stub and rspec allow when calling the PuppetX::Binford2k::NodeEncrypt.decrypt method on Ruby 2.x only. Voted by the team to skip, as test case will be removed in #94 with the removal of the deprecated node_encrypt::file defined type.
jordanbreen28
force-pushed
the
CONT-1048-remove_deprecated_file_type
branch
from
bcbd308 to
2c0da98
Compare
This commit removes the now deprecated node_encrypt::file defined type. This type was retained for backwards code compatiblity, but was just a wrapper for the deferred function. This commit removes this deprecated defined type, in preparation of the upcoming major release.
jordanbreen28
force-pushed
the
CONT-1048-remove_deprecated_file_type
branch
from
2c0da98 to
1a83267
Compare
GSPatton
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated node_encrypt::file defined type. This type was retained for backwards code compatibility, but was just a wrapper for the node_encrypt::secret function.
This PR removes this deprecated defined type, in preparation of the upcoming major release.